From b7fe8f681c6c15ed23d296ac65098c18a571fb34 Mon Sep 17 00:00:00 2001
From: "Patrik J. Braun" <bra.patrik@gmail.com>
Date: Sat, 11 Mar 2023 14:24:55 +0100
Subject: [PATCH] Fixing settings warning badge #507

---
 src/frontend/app/model/IRenderable.ts          | 8 ++++----
 src/frontend/app/ui/frame/frame.component.css  | 1 -
 src/frontend/app/ui/frame/frame.component.html | 4 ++--
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/frontend/app/model/IRenderable.ts b/src/frontend/app/model/IRenderable.ts
index 1891966e..057ad82e 100644
--- a/src/frontend/app/model/IRenderable.ts
+++ b/src/frontend/app/model/IRenderable.ts
@@ -12,10 +12,10 @@ export interface Dimension {
 export const DimensionUtils = {
   toString: (dim: Dimension) => {
     return {
-      top: dim.top + 'px',
-      left: dim.left + 'px',
-      width: dim.width + 'px',
-      height: dim.height + 'px',
+      top: dim.top || 0 + 'px',
+      left: dim.left || 0 + 'px',
+      width: dim.width || 0 + 'px',
+      height: dim.height || 0 + 'px',
     };
   },
 };
diff --git a/src/frontend/app/ui/frame/frame.component.css b/src/frontend/app/ui/frame/frame.component.css
index 24b15c8a..31835e31 100644
--- a/src/frontend/app/ui/frame/frame.component.css
+++ b/src/frontend/app/ui/frame/frame.component.css
@@ -57,6 +57,5 @@ a.dropdown-item span, button.dropdown-item span, div.dropdown-item span {
 
 
 a.dropdown-item span.badge, button.dropdown-item span.badge {
-  padding: 0.25em 0.37rem 0.25rem 0;
   margin-left: -0.8rem;
 }
diff --git a/src/frontend/app/ui/frame/frame.component.html b/src/frontend/app/ui/frame/frame.component.html
index 05da07d7..930b0ce7 100644
--- a/src/frontend/app/ui/frame/frame.component.html
+++ b/src/frontend/app/ui/frame/frame.component.html
@@ -70,7 +70,7 @@
                         aria-controls="dropdown-alignment">
                   <span class="oi oi-menu"></span>
                   <span *ngIf="isAdmin() && notificationService.numberOfNotifications>0"
-                        class="navbar-badge badge badge-warning">{{notificationService.numberOfNotifications}}</span>
+                        class="navbar-badge badge text-bg-warning">{{notificationService.numberOfNotifications}}</span>
                 </button>
                 <ul id="dropdown-alignment" *dropdownMenu
                     class="dropdown-menu dropdown-menu-right"
@@ -138,7 +138,7 @@
                     <a class="dropdown-item" [routerLink]="['/admin']">
                       <span class="oi oi-wrench"></span>
                       <span *ngIf="notificationService.numberOfNotifications>0"
-                            class="badge">{{notificationService.numberOfNotifications}}</span>
+                            class="badge rounded-pill position-absolute p-0 text-bg-warning">{{notificationService.numberOfNotifications}}</span>
                       <ng-container i18n>Settings</ng-container>
                     </a>
                   </li>