From c672b9823a9d7c6738b8520c9f6442a0f470c557 Mon Sep 17 00:00:00 2001
From: "Patrik J. Braun" <bra.patrik@gmail.com>
Date: Sun, 8 Jan 2023 11:49:32 +0100
Subject: [PATCH] Improve sharing password handling

---
 .../app/ui/gallery/share/share.gallery.component.css   |  1 +
 .../app/ui/gallery/share/share.gallery.component.html  | 10 ++++++----
 .../app/ui/gallery/share/share.gallery.component.ts    |  1 +
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/frontend/app/ui/gallery/share/share.gallery.component.css b/src/frontend/app/ui/gallery/share/share.gallery.component.css
index 8af9f05f..91505bfe 100644
--- a/src/frontend/app/ui/gallery/share/share.gallery.component.css
+++ b/src/frontend/app/ui/gallery/share/share.gallery.component.css
@@ -14,3 +14,4 @@
 #shareButton span {
   padding-right: 0.3rem;
 }
+
diff --git a/src/frontend/app/ui/gallery/share/share.gallery.component.html b/src/frontend/app/ui/gallery/share/share.gallery.component.html
index 826eb293..6598a237 100644
--- a/src/frontend/app/ui/gallery/share/share.gallery.component.html
+++ b/src/frontend/app/ui/gallery/share/share.gallery.component.html
@@ -9,7 +9,7 @@
   <!-- sharing Modal-->
   <div class="modal-header">
     <h5 class="modal-title" i18n>Share</h5>
-    <button type="button"  class="btn-close"  (click)="hideModal()" data-dismiss="modal" aria-label="Close">
+    <button type="button" class="btn-close" (click)="hideModal()" data-dismiss="modal" aria-label="Close">
     </button>
   </div>
   <div class="modal-body">
@@ -21,7 +21,9 @@
                  placeholder="link"
                  class="form-control input-md"
                  type="text"
-                 [ngModel]="url">
+                 readonly
+                 [disabled]="!shareForm.form.valid"
+                 [ngModel]="shareForm.form.valid ? url: invalidSettings">
         </div>
         <div class="col-5 col-sm-3">
           <button id="copyButton" name="copyButton"
@@ -68,14 +70,14 @@
         </div>
       </div>
 
-      <div class="row">
+      <div class="row" *ngIf="passwordProtection">
         <div class="col-4">
           <label class="control-label" for="share-password">
             <ng-container i18n>Password</ng-container>
             *:
           </label>
         </div>
-        <div class="col-8" *ngIf="passwordProtection">
+        <div class="col-8">
           <input id="share-password"
                  class="form-control"
                  name="share-password"
diff --git a/src/frontend/app/ui/gallery/share/share.gallery.component.ts b/src/frontend/app/ui/gallery/share/share.gallery.component.ts
index 6e3dc814..d7234d70 100644
--- a/src/frontend/app/ui/gallery/share/share.gallery.component.ts
+++ b/src/frontend/app/ui/gallery/share/share.gallery.component.ts
@@ -34,6 +34,7 @@ export class GalleryShareComponent implements OnInit, OnDestroy {
   readonly ValidityTypes = ValidityTypes;
 
   modalRef: BsModalRef;
+  invalidSettings = $localize`Invalid settings`
 
   text = {
     Yes: 'Yes',