diff --git a/src/backend/model/tasks/tasks/DBResetTask.ts b/src/backend/model/tasks/tasks/DBResetTask.ts index 743dd753..c573f28a 100644 --- a/src/backend/model/tasks/tasks/DBResetTask.ts +++ b/src/backend/model/tasks/tasks/DBResetTask.ts @@ -10,6 +10,7 @@ const LOG_TAG = '[DBRestTask]'; export class DBRestTask extends Task { public readonly Name = DefaultsTasks[DefaultsTasks['Database Reset']]; public readonly ConfigTemplate: ConfigTemplateEntry[] = null; + protected readonly IsInstant = true; public get Supported(): boolean { return Config.Server.Database.type !== ServerConfig.DatabaseType.memory; diff --git a/src/backend/model/tasks/tasks/Task.ts b/src/backend/model/tasks/tasks/Task.ts index 039b5663..4436370d 100644 --- a/src/backend/model/tasks/tasks/Task.ts +++ b/src/backend/model/tasks/tasks/Task.ts @@ -11,12 +11,14 @@ export abstract class Task implements ITask { protected state = TaskState.idle; protected config: T; protected prResolve: () => void; + protected IsInstant = false; public abstract get Supported(): boolean; public abstract get Name(): string; + public abstract get ConfigTemplate(): ConfigTemplateEntry[]; @@ -44,6 +46,9 @@ export abstract class Task implements ITask { this.init().catch(console.error); this.state = TaskState.running; this.run(); + if (!this.IsInstant) { // if instant, wait for execution, otherwise, return right away + return Promise.resolve(); + } return pr; } else { Logger.info('[Task]', 'Task already running: ' + this.Name); @@ -71,7 +76,9 @@ export abstract class Task implements ITask { private onFinish(): void { this.progress = null; Logger.info('[Task]', 'Task finished: ' + this.Name); - this.prResolve(); + if (this.IsInstant) { + this.prResolve(); + } } private run() { diff --git a/src/frontend/app/ui/settings/photo/photo.settings.component.ts b/src/frontend/app/ui/settings/photo/photo.settings.component.ts index 8ae9df17..ca67938f 100644 --- a/src/frontend/app/ui/settings/photo/photo.settings.component.ts +++ b/src/frontend/app/ui/settings/photo/photo.settings.component.ts @@ -68,16 +68,16 @@ export class PhotoSettingsComponent extends SettingsComponent<{ try { await this.tasksService.start(DefaultsTasks[DefaultsTasks['Photo Converting']]); this.notification.info(this.i18n('Photo converting started')); - this.inProgress = false; return true; } catch (err) { console.log(err); if (err.message) { this.error = (err).message; } + } finally { + this.inProgress = false; } - this.inProgress = false; return false; } @@ -87,16 +87,16 @@ export class PhotoSettingsComponent extends SettingsComponent<{ try { await this.tasksService.stop(DefaultsTasks[DefaultsTasks['Photo Converting']]); this.notification.info(this.i18n('Photo converting interrupted')); - this.inProgress = false; return true; } catch (err) { console.log(err); if (err.message) { this.error = (err).message; } + } finally { + this.inProgress = false; } - this.inProgress = false; return false; } } diff --git a/src/frontend/app/ui/settings/scheduled-tasks.service.ts b/src/frontend/app/ui/settings/scheduled-tasks.service.ts index c191f81b..bdbc88f3 100644 --- a/src/frontend/app/ui/settings/scheduled-tasks.service.ts +++ b/src/frontend/app/ui/settings/scheduled-tasks.service.ts @@ -36,8 +36,8 @@ export class ScheduledTasksService { this.decSubscribers(); } - public forceUpdate() { - return this.getProgress(); + public async forceUpdate(): Promise { + return await this.getProgress(); } public async start(id: string, config?: any): Promise { @@ -50,7 +50,7 @@ export class ScheduledTasksService { this.forceUpdate(); } - protected async getProgress() { + protected async getProgress(): Promise { const prevPrg = this.progress.value; this.progress.next(await this._networkService.getJson<{ [key: string]: TaskProgressDTO }>('/admin/tasks/scheduled/progress')); for (const prg in prevPrg) { diff --git a/src/frontend/app/ui/settings/tasks/progress/progress.tasks.settings.component.html b/src/frontend/app/ui/settings/tasks/progress/progress.tasks.settings.component.html index 38be99c0..9fa616bf 100644 --- a/src/frontend/app/ui/settings/tasks/progress/progress.tasks.settings.component.html +++ b/src/frontend/app/ui/settings/tasks/progress/progress.tasks.settings.component.html @@ -14,6 +14,7 @@
{{TimeElapsed| duration}}
+
+
{{TimeAll| duration}}