1
0
mirror of https://github.com/xuthus83/pigallery2.git synced 2024-11-03 21:04:03 +08:00
Commit Graph

2410 Commits

Author SHA1 Message Date
grasdk
75d81d42bd
Feature/caption and title (#14)
* reading caption and title from several tags with several tests added
minor bugfix for date conversion to MS
optimization: break sidecar loop, when first sidecar is found
2024-03-31 14:57:20 +02:00
sarayourfriend
409af3898b
Narrow LoggerArgs types and fix bad revert 2024-03-31 09:45:16 +11:00
sarayourfriend
2b26b3744b
Revert "Remove duplicative logging"
This reverts commit 25fb0ddb531a29dcc0fcefeedb986a1451d669b6.
2024-03-31 09:45:16 +11:00
sarayourfriend
fcdb2f2938
Revert "Always use Logger class and try to log once per event"
This reverts commit a57a717717a676555b4e28d5746828477c2f9811.
2024-03-31 09:45:16 +11:00
sarayourfriend
b0c2f8da04
Always use Logger class and try to log once per event
This unifies logging across the backend to always use the Logger class,
always only logs to stdout (rather than an inconsistent mix of stdout
and stderr, depending on whether console.error was used), and removes
logging where two log events happened for the same message

For example, this pattern:

```js
Logger.error("Whoops, something went wrong:")
console.error(err)
```

That causes two separate log events, and depending on the log transport
used, could cause relevant log messages to get split across multiple
events and therefore be harder (usually just more tedious) to connect
and debug in production environments.
2024-03-31 09:45:16 +11:00
sarayourfriend
ba6e7c03ec
Always use Logger class and try to log once per event
This unifies logging across the backend to always use the Logger class,
always only logs to stdout (rather than an inconsistent mix of stdout
and stderr, depending on whether console.error was used), and removes
logging where two log events happened for the same message

For example, this pattern:

```js
Logger.error("Whoops, something went wrong:")
console.error(err)
```

That causes two separate log events, and depending on the log transport
used, could cause relevant log messages to get split across multiple
events and therefore be harder (usually just more tedious) to connect
and debug in production environments.
2024-03-31 09:45:16 +11:00
sarayourfriend
3be8f1b194
Remove duplicative logging
These log calls either duplicated the generic error renderer logging or neighbouring log calls
2024-03-31 09:45:16 +11:00
sarayourfriend
5c8e01c034
Configure log levels for specific error types 2024-03-31 09:45:16 +11:00
sarayourfriend
fae2980692
Remove dead code 2024-03-31 09:45:16 +11:00
sarayourfriend
7cf7febc5c
Remove duplicative logFN type 2024-03-31 09:45:16 +11:00
Patrik J. Braun
086bc47a01
Merge pull request #868 from grasdk/master
Metadata mapping and consolidation
2024-03-30 22:12:29 +01:00
gras
78fbc942b9 mediaentity rating back to unsigned 2024-03-30 22:04:07 +01:00
gras
9aab44b7af Removed 0 as a rating, since it means unrated. 2024-03-30 21:23:10 +01:00
gras
b071b6daae xmp-rating valid values now 1-5. 0 means "unrated" and the attribute does not exist with value 0 2024-03-30 21:07:41 +01:00
Patrik J. Braun
1e0dbc08dc
Merge pull request #862 from sarayourfriend/fix/numerical-file-sort
Trim extensions when sorting filenames
2024-03-30 19:31:00 +01:00
gras
77982e6c10 changed database to be able to contain rating -1 2024-03-30 15:59:38 +01:00
gras
9e7acc46c1 gps coordinate undefined check + rating update 2024-03-30 15:31:16 +01:00
gras
a8b00d549b changed orientation to const 2024-03-30 14:13:47 +01:00
grasdk
1514662b8d
Feature/metadata sidecar reading cleanup (#13)
* Removed the SideCar Type to make reading sidecar data just as generic as reading the embedded exif data

* Moved metadata-mapping into separate function to prepare for reuse

* Most sidecar metadata is now read with the same function as embedded metadata (for photos). Fixed a bug with rating: 0 being ignored

* added new test for special chars and timezone

* merge incoming changes

* xmp rating fix - 0 is a value. prep for xmp timestamp handling

* refactored mapping of metadata into smaller functions

* consolidated GPS coordinate mapping

* simplification of sidecar date reading logic

* Moved date mapping code into one function - fixed testdata - did not yet resolve offset bug

* CreationDateOffset is now mapped from Sidecar timestamps. Tests updated accordingly.


Total: changed sidecar reading for video to shared reader and fixed tests accordingly (more data is read now)
2024-03-30 13:58:06 +01:00
sarayourfriend
c44110d4a6
Trim extensions when sorting filenames 2024-03-29 16:09:23 +11:00
Patrik J. Braun
fafab0db18 Disable broken test 2024-03-26 00:45:30 +01:00
Patrik J. Braun
663b5bff95 remove debug logging 2024-03-26 00:30:15 +01:00
Patrik J. Braun
6149e869d1 let flaky test through CI 2024-03-26 00:28:37 +01:00
Patrik J. Braun
4176123865 test logging.. 2024-03-26 00:16:29 +01:00
Patrik J. Braun
fc20126f0e test logging.. 2024-03-26 00:15:58 +01:00
Patrik J. Braun
01e6b60aa4 Disable extensions for settings integration test 2024-03-26 00:09:32 +01:00
Patrik J. Braun
6b3a208794 Improving integration tests. 2024-03-25 23:10:10 +01:00
Patrik J. Braun
ed0ea40758 Improving integration tests. 2024-03-25 22:51:27 +01:00
Patrik J. Braun
78b72e2528 Fix integration tests port race condition 2024-03-25 22:21:18 +01:00
Patrik J. Braun
7f65dfd1b2 Check if folder exists before listing it. 2024-03-25 21:47:05 +01:00
Patrik J. Braun
743d29b208 Merge remote-tracking branch 'origin/master'
# Conflicts:
#	src/backend/model/extension/ExtensionConfigWrapper.ts
2024-03-25 21:39:41 +01:00
Patrik J. Braun
d4d8dcfcdb Fix extension loading #784, #847, fixes #855 2024-03-25 21:38:09 +01:00
Patrik J. Braun
d0c59244ae
Merge pull request #860 from martyone/xmp-no-rating
Deal with rating missing in XMP sidecars
2024-03-24 21:34:20 +01:00
Martin Kampas
8517430a1b Deal with rating missing in XMP sidecars
Avoid getting Rating of 0 when rating metadata is not included in a
sidecar.
2024-03-23 12:44:30 +01:00
Patrik J. Braun
e3a0f5967c
Merge pull request #859 from martyone/xmp-gps
Read GPS coordinates from XMP sidecar too
2024-03-23 10:02:17 +01:00
Martin Kampas
1d1df01a68 Read GPS coordinates from XMP sidecar too 2024-03-22 15:44:22 +01:00
Patrik J. Braun
40e8147883
Merge pull request #855 from mblythe86/issue847
Fix extension configuration loading issue
2024-03-20 08:20:29 +01:00
Patrik J. Braun
5f0a7a1873
Merge pull request #841 from martyone/xmp-time
Read creation date from XMP sidecar too
2024-03-20 08:18:52 +01:00
Matthew Blythe
e89af221c9 Fix extension configuration loading issue 2024-03-19 02:00:42 -06:00
grasdk
35839ef732 test-fixing 2024-03-14 10:41:41 +01:00
Martin Kampas
6a52d84881 Add tests for reading sidecar files
Thanks grasdk for providing the .json files!

Co-authored-by: grasdk <chrisc.gigamail@gmail.com>
2024-03-13 20:03:26 +01:00
Martin Kampas
da0b7d8e21 Allow for "xap" ns prefix instead of "xmp" 2024-03-13 20:03:26 +01:00
Martin Kampas
03e0822181 Improve on reading dates from XMP sidecars 2024-03-13 20:03:26 +01:00
Martin Kampas
98a78e34fe Move utilities for parsing time stamps to Utils
These will be needed from the loadVideoMetadata as well.
2024-03-13 20:01:47 +01:00
Martin Kampas
6173350a69 Fix errors reading properties of undefined 2024-03-13 19:29:13 +01:00
Patrik J. Braun
3ec3b5a030
Merge pull request #839 from kagahd/issue838
bug fixes of both issues of #838
2024-03-12 23:07:09 +01:00
kagahd
d8c064857f
re-enable unit test that keywords from photo are merged with keywords from sidecar 2024-03-12 08:48:55 +01:00
Kay Agahd
f356eae957
Merge pull request #1 from grasdk/feature/kagahd_issue838
Added read of CreationDate to sidecar and fixed tests
2024-03-12 07:06:30 +00:00
grasdk
390e24a2c4 Added read of CreationDate to sidecar and fixed tests 2024-03-11 23:47:44 +01:00
kagahd
a2fc61320d
resolve merge conflicts for a second time due to bug in PR #829 2024-03-11 08:45:44 +01:00